Repository navigation
fix(server): settle Codex turns when the app-server exits - #167
Merged
Merged
Conversation
|
Observe process exit independently of stdout EOF and allow a bounded final drain. A descendant retaining the pipe no longer strands active requests or turn termination. Cover final replies, unterminated notifications, and signal exits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A Codex app-server can exit while turns are still active. T3 previously tried to interrupt the dead process and could leave native turns marked running. A descendant retaining stdout could also prevent T3 from observing the exit at all, stranding outstanding requests and the active turn.
Changes
Validation
The inherited-stdout regression failed before the transport fix and passes afterward. It covers ordinary EOF, an open inherited pipe, and signal exit, with final replies and notifications in each case.
vp run check:changed HEAD --concurrency 1command was run. Its cached typecheck launcher cannot initialize the workspace's nested seccomp supervisor. Cargo was initially absent from that command's PATH; the native build and the skipped test step were subsequently run successfully with the installed toolchain.The earlier run-finalization regressions and full hosted CI passed on the preceding head. Hosted CI is being rerun for this transport follow-up.
Model and harness: GPT-6.2 Astra in Codex for the original fix; GPT-6 Astra Pro in the ChatGPT shared workspace with delegated review for the deeper inspection.